This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement the Security & Privacy tab of new room settings #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failures are expected because branch mismatch |
jryans
approved these changes
Jan 30, 2019
| */ | ||
|
|
||
| .mx_SecurityRoomSettingsTab label { | ||
| display: block; |
There was a problem hiding this comment.
Minor style nit: Use 4 spaces for indentation.
There was a problem hiding this comment.
I'm going to fix all of the CSS I've added for settings in one go because they're all at 2 spaces.
turt2live
added a commit
that referenced
this pull request
Mar 22, 2019
Fixes element-hq/element-web#9235 The global option in user settings is unaffected by this bug. Users who have previously set the per-room flag without success can simply refresh the page and the change will be picked up. The bug here is that the current session would not update accordingly, however. Introduced in #2523
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8256
Part of element-hq/element-web#7606